fix: rename CZKT to LNA (Linea) #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xksure
commented
Apr 11, 2023
src/base.ts
Outdated
| @@ -183,7 +183,7 @@ export enum ChainId { | |||
| EVMT = 9000, | |||
| MORT = 1287, | |||
| FTMT = 4002, | |||
| CZKT = 59140, | |||
| LNA = 59140, | |||
There was a problem hiding this comment.
Is LNA a good acronym for Linea?
0xksure
commented
Apr 11, 2023
| // multicallAddress: multicallAddresses[ChainId.CZKT], // Not deployed yet | ||
| faucetUrls: ['https://goerli.zkevm.consensys.net/'], | ||
| // multicallAddress: multicallAddresses[ChainId.LNA], // Not deployed yet | ||
| faucetUrls: ['https://faucetlink.to/goerli'], |
There was a problem hiding this comment.
Adviced to bridge goerli to Linea https://docs.linea.build/use-linea/fund
src/base.ts
Outdated
| @@ -117,7 +117,7 @@ export enum ChainKey { | |||
| EVMT = 'evmt', | |||
| MORT = 'mort', | |||
| FTMT = 'ftmt', | |||
| CZKT = 'czkt', | |||
| LNA = 'lna', | |||
There was a problem hiding this comment.
One thing I don't know: Is this a testnet now that will be a mainnet at some point? Do we need Linea and Linea Testnet?
Will try to find that out
There was a problem hiding this comment.
Seems like Linea is the network, and the testnet is just Linea (Goerli) Testnet. So LNAT?
There was a problem hiding this comment.
Maybe add the rpc as well:
mathiasmoeller
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://lifi.atlassian.net/browse/LF-2753
Consensys ZK testnet has been renamed to Linea