Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: new types for status endpoint #166

Merged
merged 10 commits into from
Jun 6, 2023
Merged

feat!: new types for status endpoint #166

merged 10 commits into from
Jun 6, 2023

Conversation

melianessa
Copy link
Contributor

No description provided.

@melianessa melianessa added the WIP label Apr 28, 2023
@melianessa melianessa changed the title feat: new types for status endpoint feat(status refactoring): new types for status endpoint May 11, 2023
@melianessa melianessa removed the WIP label May 11, 2023
@H3xept
Copy link
Contributor

H3xept commented May 18, 2023

make sure to remove dist with git rm and re-add it to the gitignore

.gitignore Outdated
@@ -85,7 +85,7 @@ out

# Nuxt.js build / generate output
.nuxt
dist
#dist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do this to work in BE with your types changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll revert it when BE PRs are ready to be merged, only changes in api.ts will remain

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use yarn link so you don't have to check in the dist folder. Other than that, nice!

@melianessa melianessa requested a review from 0xksure May 25, 2023 07:47
@melianessa melianessa changed the title feat(status refactoring): new types for status endpoint feat(status refactoring)!: new types for status endpoint Jun 6, 2023
@melianessa melianessa changed the title feat(status refactoring)!: new types for status endpoint feat!: new types for status endpoint Jun 6, 2023
@melianessa melianessa merged commit b7262e2 into main Jun 6, 2023
4 checks passed
@melianessa melianessa deleted the LF-2926 branch June 6, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants