Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replace ethers transaction request with custom implementation #211

Merged
merged 3 commits into from
Jan 3, 2024
Merged

feat!: replace ethers transaction request with custom implementation #211

merged 3 commits into from
Jan 3, 2024

Conversation

mathiasmoeller
Copy link
Member

@mathiasmoeller mathiasmoeller commented Dec 27, 2023 •
edited

This reduces the dependencies on ethers as a first step for a viem migration.
This does everything: #183
But we want to do it in steps

@myz1237
Copy link
Contributor

myz1237 commented Dec 27, 2023

so we may have subsequent steps to replace "@ethersproject/bignumber" with self-defined TransactionRequest?

@mathiasmoeller
Copy link
Member Author

yes, all steps are here: #183
But we need to break it down in smaller chunkgs

@mathiasmoeller mathiasmoeller merged commit 5ea2253 into main Jan 3, 2024
4 checks passed
@mathiasmoeller mathiasmoeller deleted the tx-request branch January 3, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myz1237 myz1237 myz1237 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mathiasmoeller @myz1237