Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added required types for LF-672 #48

Merged
merged 6 commits into from
May 3, 2022
Merged

feat: added required types for LF-672 #48

merged 6 commits into from
May 3, 2022

Conversation

H3xept
Copy link
Contributor

@H3xept H3xept commented Apr 20, 2022

Even though the suggested types were

type ToolsResponse = {
  exchanges: Exchange[]
  bridges: Bridge[]
}

type Exchange = {
  tool: ExchangeTools
  chains: number[]
}

I have renamed them to

export type ExternalExchange = {
  tool: ExchangeTools
  chains: number[]
}
export type ExternalBridge = {
  tool: BridgeTool
  chains: number[]
}

to avoid collision with the already declared types Exchange and Bridge.

Copy link
Member

@mathiasmoeller mathiasmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@H3xept H3xept merged commit 9ff0c74 into main May 3, 2022
@H3xept H3xept deleted the LF-678 branch May 3, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants