feat: extend order type #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+12
to
+13
| export const _Order = ['RECOMMENDED', 'FASTEST', 'CHEAPEST', 'SAFEST'] as const | ||
| export type Order = typeof _Order[number] |
There was a problem hiding this comment.
Why do you need this? Also _ usually indicates a private property so exporting it feels a bit weird I think?
There was a problem hiding this comment.
We need this for route priority selection in the widget. I made it like this to follow other unions naming in this file. We can rename it if needed. 🙂
There was a problem hiding this comment.
yeah but other unions are not exported ;) Please rename it.
Maybe simply something like Orders? Or PossibleOrders?
There was a problem hiding this comment.
Great, are you taking care of changing it? :) Thanks!
There was a problem hiding this comment.
Yes, already been published. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.