Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Token): refactor token type #8

Merged
merged 3 commits into from
Dec 9, 2021
Merged

feat(Token): refactor token type #8

merged 3 commits into from
Dec 9, 2021

Conversation

mathiasmoeller
Copy link
Member

@mathiasmoeller mathiasmoeller commented Dec 8, 2021 •
edited

  • Rename token id to address to be more consistent with other implementations
  • Remove Lifi specific chainKey from tokens
  • Rename key to coinKey and make it optional
  • Make logoURI optional
  • Use ChainId in coins to identify chains
  • Build generator function to build defaultCoins

@mathiasmoeller mathiasmoeller mentioned this pull request Dec 8, 2021
Merged
maxklenk
maxklenk reviewed Dec 8, 2021
View reviewed changes
src/coins.ts Outdated Show resolved Hide resolved
maxklenk
maxklenk reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@maxklenk maxklenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only to improve this would be renaming findDefaultCoinOnChain

@mathiasmoeller mathiasmoeller merged commit ce444ce into main Dec 9, 2021
@mathiasmoeller mathiasmoeller deleted the LF-92 branch December 9, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxklenk maxklenk Awaiting requested review from maxklenk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mathiasmoeller @maxklenk