Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill time includes prerequisites #15

Open
sylvainhalle opened this issue Feb 20, 2017 · 1 comment
Open

Kill time includes prerequisites #15

sylvainhalle opened this issue Feb 20, 2017 · 1 comment
Milestone

Comments

@sylvainhalle
Copy link
Contributor

When an experiment has to generate prerequisites before running, its execution time includes that process. This means that an experiment may get killed by the assistant while it is still generating the prerequisites.

An experiment should have two "start" times: the start of the whole process, and the start of the run method. Timeout should apply to the second, not the first.

@sylvainhalle sylvainhalle added this to the v2.10 milestone Sep 6, 2017
@sylvainhalle
Copy link
Contributor Author

In a nutshell:

  • Add a new status RUNNING_PREREQ when the experiment is generating its prerequisites
  • Split the m_maxDuration field into max duration for prerequisites and execution
  • Split the getRunningTime() method in the same way
  • Adjust the LinearAssistant to timeout experiments according to prerequisites or running max durations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants