Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket-Origin should be Sec-WebSocket-Origin? #3

Closed
igorw opened this issue Jun 5, 2010 · 3 comments
Closed

WebSocket-Origin should be Sec-WebSocket-Origin? #3

igorw opened this issue Jun 5, 2010 · 3 comments

Comments

@igorw
Copy link

igorw commented Jun 5, 2010

http://www.whatwg.org/specs/web-socket-protocol/

The websockets spec only mentions Sec-WebSocket-Origin and Sec-WebSocket-Location. WebScoket-Origin and WebSocket-Locations are not mentioned. This leads me to believe that there should be a Sec- prefix.

Patch: http://gist.github.com/426773

@igorw
Copy link
Author

igorw commented Jun 5, 2010

I'm not sure, but it might also be related to: http://axod.blogspot.com/2010/06/websocket-gets-update-and-it-breaks.html

@igorw
Copy link
Author

igorw commented Jun 5, 2010

And apparently it is. Looking at a dev branch for the WebSockets-76 draft from em-websockets exactly this appears to be the case:

http://github.com/mloughran/em-websocket/tree/draft76/lib/em-websocket/
http://github.com/mloughran/em-websocket/blob/draft76/lib/em-websocket/handler75.rb
http://github.com/mloughran/em-websocket/blob/draft76/lib/em-websocket/handler76.rb

Would be great to have cramp compatible ASAP.

@andriytyurnikov
Copy link

see maccman/cramp fork, he implemented websockets-76

@lifo lifo closed this as completed Aug 11, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants