Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of testFuncNames #1449

Closed
japgolly opened this issue May 12, 2013 · 2 comments
Closed

Allow configuration of testFuncNames #1449

japgolly opened this issue May 12, 2013 · 2 comments
Assignees
Milestone

Comments

@japgolly
Copy link
Contributor

https://groups.google.com/forum/?fromgroups=#!topic/liftweb/HEUUXxPPkRs

In test-mode, an attempt is made to give function names deterministic IDs. With the ID calculation being based on the stacktrace, there are scenarios where the same ID is providing for differing functions, the practical impact of which, can be "User clicks button B, Lift reacts as if user clicked button A".

Currently the only way to disable this test feature is to wrap code in S.disableTestFunc which can be impractical if required more than a few times. More configuration of this behaviour is desired. (Example, disable completely, disable for particular snippet/request.)

@farmdawgnation
Copy link
Member

So, @japgolly is this satisfied by the existence of funcNameGenerator? I noticed this thread predates that implementation...

@japgolly
Copy link
Contributor Author

japgolly commented Dec 1, 2014

Oh hi @farmdawgnation. Yes, I am. I submitted the patch that provides LiftRules.funcNameGenerator. I think this issue here being open is an oversight. I must've forgotten to close it after the others patches got accepted. Sorry about that! Closing...

@japgolly japgolly closed this as completed Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants