Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CometActors from page #1655

Open
gvdm opened this issue Jan 4, 2015 · 3 comments
Open

Removing CometActors from page #1655

gvdm opened this issue Jan 4, 2015 · 3 comments
Projects
Milestone

Comments

@gvdm
Copy link

gvdm commented Jan 4, 2015

As per the discussion at https://groups.google.com/forum/#!topic/liftweb/u3qN8mVUpnI and as Antonio pointed out in that conversation, this is a feature which is likely to be multi-faceted.

Removing the CometActor from the client side only is probably simplest and provided via a function such as lift.stopListeningToComet as Antonio has suggested.

The other option is doing it on the server - a S.removeComet to correspond
to S.findOrCreateComet. That could do a lot better cleanup handling, including unsubscribing clients,
shutting down the comet immediately, and removing it from the session's comet list. On the flip side,
that would have to deal with potential timing issues with, say, clients in multiple tabs/windows that
have perhaps already sent something to the comet for processing, etc etc.

Even just a client side shutdown which would allow server side GC to kick in properly would be awesome by itself.

@Shadowfiend Shadowfiend added this to the 3.1 milestone Nov 26, 2015
@Shadowfiend Shadowfiend modified the milestones: 3.2.0-M1, 3.1.0-RC1, 3.2.0-M2 Apr 22, 2017
@Shadowfiend
Copy link
Member

I'll be trying to do some deeper work on comet plumbing for the 3.2 cycle, time willing. I've got many other improvements in ideation/half-implemented stages, but it's going to take some time. I'd like to roll this in with those; if anyone else wants to pick it up, though, please feel free.

@Shadowfiend Shadowfiend reopened this Apr 22, 2017
@farmdawgnation farmdawgnation modified the milestones: 3.2.0-M2, 3.2.0-M3 Sep 15, 2017
@Bhashit
Copy link
Contributor

Bhashit commented Nov 5, 2017

This sounds interesting. I'd like to give it a shot unless you are already working on it.

@Shadowfiend
Copy link
Member

Go for it. My deeper work on comets got shelved in favor of #1876, which can't really go in until a major version bump… That kind of made me stumble in general, so those changes are still in nascent stage and won't be making it into 3.2.

@farmdawgnation farmdawgnation modified the milestones: 3.2.0-M3, 3.2.0-RC1 Nov 17, 2017
@farmdawgnation farmdawgnation modified the milestones: 3.2.0-RC1, 3.3.0-M1 Dec 14, 2017
@farmdawgnation farmdawgnation modified the milestones: 3.3.0-M1, 3.3.0-M2 Feb 8, 2018
@farmdawgnation farmdawgnation modified the milestones: 3.3.0-M2, 3.3.0-M3 Apr 14, 2018
@farmdawgnation farmdawgnation modified the milestones: 3.3.0-M3, 3.3.0-RC1 Jun 2, 2018
@farmdawgnation farmdawgnation modified the milestones: 3.3.0-RC1, 3.4.0-M1 Jul 11, 2018
@farmdawgnation farmdawgnation added this to To do in Lift 3.4.0 Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Lift 3.4.0
  
To do
Development

No branches or pull requests

4 participants