Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track down usages of lines and convert to linesIterator #1966

Closed
farmdawgnation opened this issue Jul 21, 2019 · 2 comments
Closed

Track down usages of lines and convert to linesIterator #1966

farmdawgnation opened this issue Jul 21, 2019 · 2 comments
Assignees
@farmdawgnation
Labels
P:High
Projects
Lift 3.4.0

Comments

@farmdawgnation
Copy link
Member

The issue scala/bug#11125 means that we need to track down usages of StringOps.lines and replace it with linesIterator in order to be safe.

We discovered this in #1953 while working on the JDK 11 and 12 builds.
@farmdawgnation farmdawgnation self-assigned this Jul 21, 2019
@farmdawgnation farmdawgnation added this to To do in Lift 3.4.0 via automation Jul 21, 2019
@farmdawgnation
Copy link
Member Author

I did a full search of the codebase for .lines across all *.scala files and only find one other area where we seem to invoke a function called lines. That is on the CompleteMenu object which defines its parts as a variable named lines. Specs might have been the only place we've leaned on StringOps.lines.

@Shadowfiend you wanna double check me before I close this out?

@farmdawgnation farmdawgnation moved this from To do to Review in progress in Lift 3.4.0 Jul 27, 2019
@Shadowfiend
Copy link
Member

I'm 👍 here.

Lift 3.4.0 automation moved this from Review in progress to Done Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmdawgnation farmdawgnation

Labels
P:High
Projects
Lift 3.4.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shadowfiend @farmdawgnation