Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File uploads should provide a streaming interface #28

Closed
dchenbecker opened this issue Jun 23, 2009 · 5 comments
Closed

File uploads should provide a streaming interface #28

dchenbecker opened this issue Jun 23, 2009 · 5 comments
Labels
P:Normal

Comments

@dchenbecker
Copy link
Member

The current file upload API slurps the whole file into a byte array. This could exhaust server memory for large concurrency and/or large files. Add an API that allows streaming access.
@timperrett
Copy link
Contributor

Couldnt agree more with this - Derek, do you want to collaborate on making this happen?

@dchenbecker
Copy link
Member Author

Sure thing. I think we can do this without major changes to Lift's guts. The simplest would be to add a flag to LiftRules to control whether the contents are sucked into a byte array or just grabbed as an input stream. Better would be modifying it so that FileParamHolder carries the input stream and maybe just has a utility method on it to return a byte array.

@dpp
Copy link
Member

dpp commented Jul 7, 2009

Finished

@github-importer
Copy link

Imported from GitHub: http://github.com/dpp/liftweb/issues/28/find

@github-importer
Copy link

Imported from Assembla: http://www.assembla.com/spaces/liftweb/tickets/28

@tjweir tjweir mentioned this issue Mar 1, 2012
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P:Normal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timperrett @dpp @dchenbecker @github-importer