Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with record field initialisation #354

Closed
timperrett opened this issue Feb 18, 2010 · 5 comments
Closed

Bug with record field initialisation #354

timperrett opened this issue Feb 18, 2010 · 5 comments

Comments

@timperrett
Copy link
Contributor

There is an initialisation error with record in that the introspect method is not called if you make a new instance with the new language keyword. Basicaly, its all b0rked if you dont use createRecord

@Dridus
Copy link
Contributor

Dridus commented Feb 18, 2010

@Dridus
Copy link
Contributor

Dridus commented Feb 18, 2010

@Dridus
Copy link
Contributor

Dridus commented Aug 21, 2010

so this doesn't work in 2.8, because the order of initialization has changed. in 2.8, the object singletons for the subclass (e.g. Author) are not yet initialized and so return "null" at the time the superclass (Record) constructor is run. this means that none of the names ever get initialized.

I think we will have to reverse part of this change, and move the introspection back to createRecord. I'll bring it up on the ML, but I can't make screen support work on record as-is in 2.8, since screen wants field.name to be initialized.

@Dridus
Copy link
Contributor

Dridus commented Aug 24, 2010

http://reviewboard.liftweb.net/r/425/

code up on rmm_wip_479_2.7 and rmm_wip_479_2.8

@github-importer
Copy link

Imported from Assembla: http://www.assembla.com/spaces/liftweb/tickets/354

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants