Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hyphen to _ #87

Closed
wants to merge 2 commits into from
Closed

Change hyphen to _ #87

wants to merge 2 commits into from

Conversation

marvelm
Copy link

@marvelm marvelm commented Apr 21, 2015

I'm getting errors when building crates which depend on "encoding-index-*" crates because of the hyphen.

cargo build
Unable to get packages from source

Caused by:
failed to parse manifest at .../.cargo/registry/src/github.com-1ecc6299db9ec823/encoding-index-tradchinese-1.20141219.2/Cargo.toml

Caused by:
library target names cannot contain hyphens: encoding-index-tradchinese

@SimonSapin
Copy link
Collaborator

Aren’t you just using an older version? The latest on https://crates.io/crates/encoding-index-tradchinese is 1.20141219.5, not 1.20141219.2. Try cargo update?

@SimonSapin
Copy link
Collaborator

To clarify: I don’t think this change is necessary or that it actually fixes your issue.

@marvelm
Copy link
Author

marvelm commented Apr 21, 2015

Thank you!

@marvelm marvelm closed this Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants