Assertion in LLVM hit in unit tests for BrightenPointerOperations pass

[tetsuo-cpp]

This is with a clean Debug + ASan build off master with LLVM 12. Not sure how others are running tests, but I'm doing it via ctest.

tetsuo@Alexs-MacBook-Pro anvill % ctest --rerun-failed --output-on-failure
Test project /Users/tetsuo/Build/anvill
    Start 1: test_anvill_passes
1/1 Test #1: test_anvill_passes ...............Subprocess aborted***Exception:   0.72 sec
Pass 'Dead Code Elimination' is not initialized.
Verify if there is a pass dependency cycle.
Required Passes:
Assertion failed: (PI && "Expected required passes to be initialized"), function schedulePass, file /Users/tetsuo/dev/cxx-common/vcpkg/buildtrees/llvm-12/src/org-12.0.1-5ce32a7629.clean/llvm/lib/IR/LegacyPassManager.cpp, line 714.
[doctest] doctest version is "2.4.5"
[doctest] run with "--help" for options
===============================================================================
/Users/tetsuo/Code/anvill/libraries/anvill_passes/tests/src/BrightenPointers.cpp:97:
TEST SUITE: BrightenPointers
TEST CASE:  Run the whole pass on a well-formed function

/Users/tetsuo/Code/anvill/libraries/anvill_passes/tests/src/BrightenPointers.cpp:97: FATAL ERROR: test case CRASHED: SIGABRT - Abort (abnormal termination) signal

===============================================================================
[doctest] test cases:  3 |  2 passed | 1 failed | 36 skipped
[doctest] assertions: 10 | 10 passed | 0 failed |
[doctest] Status: FAILURE!


0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.72 sec

The following tests FAILED:
	  1 - test_anvill_passes (Subprocess aborted)
Errors while running CTest

This pass creates its own pass manager and runs a DCE pass internally which seems to be what it's complaining about.

[pgoodman]

No longer have that code.