Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image uploads to instances with image size limits fail #428

Open
mykdavies opened this issue Jul 17, 2023 · 0 comments
Open

Image uploads to instances with image size limits fail #428

mykdavies opened this issue Jul 17, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mykdavies
Copy link
Contributor

mykdavies commented Jul 17, 2023

User report: https://lemmy.world/comment/1394283

Device info

  • Liftoff version: 0.10.9

Describe the bug

We're getting a 413 Payload Too Large response which our implementation of the Pictrs API is choking on.

Steps to reproduce

  1. Logon to Lemmy.ee.
  2. Make a new post.
  3. Try to add an image.
  4. Catch the exception

Expected behavior

There's no error handling in the upload() function in pictrs.dart, so we need to add that. Not sure if the latest backend version allows sites to encode max upload sizes somewhere so we need to see if we can pick that up or just try some "small enough" size behind the scenes The backend does not support providing this information, so I've raised an enhancement request: LemmyNet/lemmy#3655

In the meantime, I'll look at just trying some "small enough" size behind the scenes and let the user know and decide if they want to try another approach.

@mykdavies mykdavies added the bug Something isn't working label Jul 17, 2023
@mykdavies mykdavies self-assigned this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant