Save bools role playing #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obs01ete
reviewed
Mar 27, 2023
| @@ -27,8 +27,6 @@ def main() -> None: | |||
| print( | |||
| Fore.CYAN + | |||
| f"Specified task prompt:\n{role_play_session.specified_task_prompt}\n") | |||
| print(Fore.MAGENTA + | |||
There was a problem hiding this comment.
In RolePlaying ctor specify else branches for if with_task_specify: to set self.specified_task_prompt = None.
For if with_task_planner: - the same.
Obs01ete
reviewed
Mar 27, 2023
| @@ -43,7 +41,7 @@ def main() -> None: | |||
| print_text_animated(Fore.GREEN + | |||
| f"AI Assistant:\n\n{assistant_msg.content}\n\n") | |||
|
|
|||
| if "<CAMEL_TASK_DONE>" in user_msg.content: | |||
There was a problem hiding this comment.
What about making "CAMEL_TASK_DONE" a class constant like self.task_done_keyword. You have it in other places
if "<CAMEL_TASK_DONE>" in user_msg.content:
Also what's the point of removing <> ?
There was a problem hiding this comment.
message_dict['termination_reason'] = "<CAMEL_TASK_DONE>"
There was a problem hiding this comment.
Sometimes the user replies with CAMEL_TASK_DONE without <>. So I remove it. Making it a class constant sounds good to me. I will fix it in following PRs.
|
All good, you can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.