Agents app #37
Agents app #37
Conversation
|
@lightaime review pls |
|
@lightaime PR is ready, pls review and merge |
There was a problem hiding this comment.
Awesome! I like it. Leave some minor comments. Please merge it after you fix them. Also please remember to fix these flake8 issues: https://github.com/lightaime/camel/actions/runs/4585128885/jobs/8097075241?pr=37. Thanks!
|
|
||
| try: | ||
| session = RolePlaying(assistant, user, original_task, | ||
| with_task_specify=True, with_task_planner=False) |
There was a problem hiding this comment.
It would be great if we can also expose with_task_specify to the UI. So people can choose if the task will be specified by CAMEL or not.
There was a problem hiding this comment.
Will put it in the backlog
apps/agents/agents.py
Outdated
| return state, state.chat, gr.update(), gr.update() | ||
|
|
||
| try: | ||
| assistant_msg, user_msg = state.session.step(state.saved_assistant_msg) |
There was a problem hiding this comment.
| assistant_msg, user_msg = state.session.step(state.saved_assistant_msg) | |
| assistant_msgs, user_msgs = state.session.step(state.saved_assistant_msg) |
apps/agents/agents.py
Outdated
| u_msg = user_msg[0] | ||
| a_msg = assistant_msg[0] |
There was a problem hiding this comment.
| u_msg = user_msg[0] | |
| a_msg = assistant_msg[0] | |
| u_msg = user_msgs[0] | |
| a_msg = assistant_msgs[0] |
| assistant_ta = gr.TextArea(label="Assistant role (EDIT ME)", | ||
| lines=1, interactive=True) | ||
| with gr.Column(scale=1): | ||
| user_dd = gr.Dropdown(user_roles, label="Example user roles", | ||
| value=user_role, interactive=True) | ||
| user_ta = gr.TextArea(label="User role (EDIT ME)", lines=1, | ||
| interactive=True) | ||
| with gr.Column(scale=1): | ||
| gr.Markdown( | ||
| "## CAMEL: Communicative Agents for \"Mind\" Exploration" | ||
| " of Large Scale Language Model Society\n" | ||
| "Github repo: [https://github.com/lightaime/camel]" | ||
| "(https://github.com/lightaime/camel)") | ||
| with gr.Row(): | ||
| with gr.Column(scale=9): | ||
| original_task_ta = gr.TextArea( | ||
| label="Give me a preliminary idea (EDIT ME)", | ||
| value=default_task, lines=1, interactive=True) |
There was a problem hiding this comment.
It would be great if we can add a markdown doc to explain the three EDIT ME fields.
There was a problem hiding this comment.
Put where? To the GUI as a static text?
There was a problem hiding this comment.
Yes, we can do that. Giving more explanations would be helpful for users
No description provided.