Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gpt-4 and gpt-4-32k support #58

Merged
merged 17 commits into from
Apr 7, 2023
Merged

added gpt-4 and gpt-4-32k support #58

merged 17 commits into from
Apr 7, 2023

Conversation

zestor
Copy link
Contributor

@zestor zestor commented Apr 6, 2023

No description provided.

@lightaime
Copy link
Member

Thanks, @zestor for the awesome pull requests! The 1st PR from the community!

I am about to add support for GPT4. You read my mind. It looks great overall! But it seems there are some things wrong with the commit history. Could you merge the current master to your branch? Thanks!

@lightaime lightaime self-requested a review April 6, 2023 19:24
@lightaime lightaime added the Agent Related to camel agents label Apr 6, 2023
@zestor
Copy link
Contributor Author

zestor commented Apr 6, 2023 via email

Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great to me. If you would like to fix the flake 8 issues would be great, otherwise, I can fix it as well. Thanks!

camel/utils.py Outdated Show resolved Hide resolved
camel/utils.py Show resolved Hide resolved
@zestor
Copy link
Contributor Author

zestor commented Apr 6, 2023 via email

@zestor
Copy link
Contributor Author

zestor commented Apr 7, 2023

I ran isort and flake8 local and made all changes. It should work.

@lightaime
Copy link
Member

lightaime commented Apr 7, 2023

I ran isort and flake8 local and made all changes. It should work.

Thank you for your contributions @zestor. Everything looks great. I added a simple test in test_chat_agent. I will go ahead and merge it.

(Although I don’t have access to gpt-4-32k and failed locally with: InvalidRequestError The model: gpt-4-32k does not exist)

@lightaime lightaime merged commit 9f1e9eb into camel-ai:master Apr 7, 2023
2 checks passed
@lightaime lightaime assigned lightaime and unassigned lightaime Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Related to camel agents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants