-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added gpt-4 and gpt-4-32k support #58
Conversation
Thanks, @zestor for the awesome pull requests! The 1st PR from the community! I am about to add support for GPT4. You read my mind. It looks great overall! But it seems there are some things wrong with the commit history. Could you merge the current master to your branch? Thanks! |
Let me check it out
…On Thu, Apr 6, 2023, 3:24 PM Guohao Li ***@***.***> wrote:
Thanks, @zestor <https://github.com/zestor> for the awesome pull
requests! The 1st PR from the community!
I am about to add support for GPT4. You read my mind. It looks great
overall! But it seems there are some things wrong with the commit history.
Could you merge the current master to your branch? Thanks!
—
Reply to this email directly, view it on GitHub
<#58 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARB4DGVZYML5MXB6IE4XKDW74J6JANCNFSM6AAAAAAWVYKCEU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great to me. If you would like to fix the flake 8 issues would be great, otherwise, I can fix it as well. Thanks!
Ok, I made the updates.
…On Thu, Apr 6, 2023 at 5:35 PM Guohao Li ***@***.***> wrote:
***@***.**** commented on this pull request.
Look great to me. If you would like to fix the flake 8 issues
<https://github.com/lightaime/camel/actions/runs/4633063547/jobs/8198197655?pr=58>
would be great, otherwise, I can fix it as well. Thanks!
------------------------------
In camel/utils.py
<#58 (comment)>:
> @@ -5,6 +5,17 @@
from camel.message import OpenAIMessage
from camel.typing import ModeType
+def count_tokens_openai_chat_models(messages: List[OpenAIMessage], encoding):
⬇️ Suggested change
-def count_tokens_openai_chat_models(messages: List[OpenAIMessage], encoding):
+def count_tokens_openai_chat_models(messages: List[OpenAIMessage], encoding: Any):
------------------------------
In camel/utils.py
<#58 (comment)>:
> from camel.message import OpenAIMessage
from camel.typing import ModeType
⬇️ Suggested change
-from camel.message import OpenAIMessage
-from camel.typing import ModeType
+from typing import Any
+
+from camel.message import OpenAIMessage
+from camel.typing import ModeType
—
Reply to this email directly, view it on GitHub
<#58 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARB4DEFZJZFON2LAGJCE43W74ZKFANCNFSM6AAAAAAWVYKCEU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Chris Clark
704.776.0862
|
I ran isort and flake8 local and made all changes. It should work. |
Thank you for your contributions @zestor. Everything looks great. I added a simple test in (Although I don’t have access to |
No description provided.