Create pytest actions for the package and the apps #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obs01ete
changed the title
lightaime
reviewed
Apr 17, 2023
| - name: Set up Python 3.8 | ||
| uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: "3.8" |
There was a problem hiding this comment.
Suggested change
| python-version: "3.8" | |
| python-version: "3.10" |
There was a problem hiding this comment.
We want to keep code compatibility with 3.8, right? @lightaime
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Set up Python 3.8 |
There was a problem hiding this comment.
Suggested change
| - name: Set up Python 3.8 | |
| - name: Set up Python 3.10 |
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Set up Python 3.8 |
There was a problem hiding this comment.
Suggested change
| - name: Set up Python 3.8 | |
| - name: Set up Python 3.10 |
| - name: Set up Python 3.8 | ||
| uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: "3.8" |
There was a problem hiding this comment.
Suggested change
| python-version: "3.8" | |
| python-version: "3.10" |
.github/workflows/pytest_package.yml
Outdated
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install flake8 pytest | ||
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi |
There was a problem hiding this comment.
Should we test pip install -e . instead?
|
We can also check it for py3.8. But the linting workflow is using py3.10z
what do you think?
…On Mon 17. Apr 2023 at 10:27, Dmitrii Khizbullin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/pytest_apps.yml
<#92 (comment)>:
> + branches: [ "master" ]
+
+permissions:
+ contents: read
+
+jobs:
+ build:
+
+ runs-on: ubuntu-latest
+
+ steps:
+ - uses: ***@***.***
+ - name: Set up Python 3.8
+ uses: ***@***.***
+ with:
+ python-version: "3.8"
We want to keep code compatibility with 3.8, right?
—
Reply to this email directly, view it on GitHub
<#92 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFUJTYATJEDG75IYYQ7XWETXBTWFRANCNFSM6AAAAAAXAJMRDE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.