-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The watch page is in some places glitched #18
Comments
Also, where is the original comment layout? Look at the screenshot earlier and look at this screenshot (It is thing for another issue, anyways sorry for off-topic):
|
Yeah, see, CustomTube only truly supports English at the moment. I have already fixed a major bug that happened in every language other than English, but supporting every language individually is something that is going to be very difficult to do, since I only speak English. I do have an idea for how to fix the reply button specifically in other languages though.
Make sure you click the "Show more" button itself. Clicking the description itself also expands the description, just like in regular YouTube. I don't know how to explain it properly so here's some screenshots (took a random video for the description): This happens when you click on the description (NOT the "Show more" button): This happens when you click on the "Show more" button specifically: I don't know why this happens, and fixing it is not really a priority.
It's planned. See, CustomTube was released because I felt like it was "good enough" for general use, but it is not actually finished. Any inaccuracy in CustomTube is something I'm most likely aware of, but haven't gotten around to yet. |
Thank you, that you will implement old comments! Good luck with implementing old comments (And mainly good luck with all your work). |
And I said:
I'm right? |
Yes. I'm not sure if I'll even be implementing the pagination. |
And, you are planning to implement JavaScript someday to CustomTube? Because this is using only CSS. |
Incorrect, the extension is already 27.5% JavaScript. Plus, I've already "Implemented JavaScript" in some ways. For example: That is not YouTube's regular view count element. CustomTube created it using JavaScript. Same with the Like to Dislike bar. |
Then sorry. But similarity to real layout is important, so I think, that the pagination should be implemented. |
Yes, a 100% accurate recreation would be ideal, but It might not be feasible. The reason I'm not guaranteeing pagination is because I've already tried to disable infinite scrolling on the comments (which would add a "Show more" button), but it proves to be more difficult than disabling the infinite scrolling of the related videos section for example. If disabling infinite scrolling is hard, then pagination will be even harder. Edit: Basically, the comment section is a pain to work with when you mess with the scrolling. |
This is beginning to feels like a discussion to me (this issue), because there are 9 comments. |
I mean you can if you want, but I mean, I'm already aware it. In fact, most of the things you brought up are things I was already aware of. The big exception being the PocketTube thing. Edit: Besides, having the proper comment section is an improvement, not a fix. |
So, I decided to create that issue, so at least we could have better control of it (e.g. If you accidentally forgot about that; Or if someone doesn't know, what feature you have to plan). I will add a “Feature request:” pre-fix to it. |
That is not a language issue, but a CSS issue, because the “Odpovedať” is a longer word than “Reply”. |
That's exactly why it's a language issue. The fix I've decided on: CustomTube adds CSS which puts the reply button on the left, rather than the right. I now realize that the method it uses is not practical for multiple languages though. So I've decided that for all languages other than English, the reply button will stay on the end on the comment, as it is in regular YouTube. Less accurate, but only slightly. |
The reply button fix has been applied in update 1.0.4. Should I close the issue? |
Wait, I will test it. |
Yes, it is fixed. And for the “show less”, then it was caused by “Enhancer for YouTube” extension, so I disabled that feature which was glitching it. |
Alright, thanks. |
Problem description:
Expected results:
Other details:
Screenshots:
The text was updated successfully, but these errors were encountered: