java-eventing-shopping-cart with codegen #282
Conversation
johanandren
force-pushed
the
wip-java-eventing-codegen
branch
from
d4ea8e9
to
01ee0d7
Compare
|
Just fixing docs to compile with these changes, let's revisit how good the docs are separately and I'll continue with testkit instead for now. |
|
|
||
| private static Logger LOG = LoggerFactory.getLogger(ShoppingCartView.class); | ||
| private static Logger LOG = LoggerFactory.getLogger(ShoppingCartViewServiceView.class); |
There was a problem hiding this comment.
Ouch... I guess our convention should be not to suffix Service to protobuf services? Anyway not directly relevant to this PR.
There was a problem hiding this comment.
Yeah, I agree it's not great, some related discussions in #238
| @@ -33,6 +33,9 @@ message TopicOperation { | |||
| } | |||
|
|
|||
| service ShoppingCartTopicService { | |||
| option (akkaserverless.service) = { | |||
| type : SERVICE_TYPE_ACTION | |||
There was a problem hiding this comment.
Do we have a protobuf style guide somewhere? I think I'd use 2-space indents and no space between type :, but I'm not sure if we decided on anything. Anyway perhaps not for this PR.
There was a problem hiding this comment.
I guess we should (at some point) lint these like we do in the framework project.
Refs #277