Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

There should be a way to override the StreamBuilder instance present inside the StreamBuilderS for unit testing. #33

Closed
shiv4nsh opened this issue Jan 11, 2018 · 3 comments · Fixed by #34
Assignees

Comments

@shiv4nsh
Copy link
Contributor

There should be a way to provide the value of inner :StreamsBuilder So that the library must not create its own version of StreamBuilder like in case of using https://github.com/jpzk/mockedstreams library for unit Testing.

For now The workaround is making a separate class that Extends StreamsBuilderS and then overriding inner there:

class StreamSTest(streamBuilder: StreamsBuilder) extends StreamsBuilderS {
  override val inner = streamBuilder
}

@debasishg debasishg self-assigned this Jan 11, 2018
@shiv4nsh
Copy link
Contributor Author

@debasishg : This is valid Right ? If you allow I can also work on this .

@debasishg
Copy link
Contributor

@shiv4nsh This will certainly be useful. But we need to maintain compatibility with the existing API. It would be great if u work on this. maybe have another constructor in the companion object that takes a StreamsBuilder ?

@shiv4nsh
Copy link
Contributor Author

@debasishg : Sure , I will make the changes and raise the PR . I will make the companion object and add the constructor that takes the StreamsBuilder and gives the instance of StreamBuilderS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants