Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Proposal to add Circe support #68

Closed
joan38 opened this issue Apr 30, 2018 · 4 comments
Closed

Proposal to add Circe support #68

joan38 opened this issue Apr 30, 2018 · 4 comments

Comments

@joan38
Copy link
Contributor

joan38 commented Apr 30, 2018

Hi,

For the people using Circe with Kafka Streams I have created a little Serde adapter: https://github.com/joan38/kafka-streams-circe

This is way too tiny to be in a separate repo on it's own so I was thinking maybe it's a good idea to add this here in a separate project.

Something like:

  • kafka-streams-core
  • kafka-streams-circe
  • docs (with sbt-microsite for example)
  • (Any other stuff here?)

Just like in https://github.com/sksamuel/elastic4s
This may solve the questions around #42

Let me know what you think. I'm more than happy to do the change.

Cheers

@joan38 joan38 changed the title Proposal to Proposal to add Circe support and separate Algebird Apr 30, 2018
@joan38 joan38 changed the title Proposal to add Circe support and separate Algebird Proposal to add Circe support Apr 30, 2018
@joan38
Copy link
Contributor Author

joan38 commented May 11, 2018

This is irrelevant now since this repo got merged in apache/kafka

@joan38 joan38 closed this as completed May 11, 2018
@DevonPeroutky
Copy link

Is there a corresponding issue in apache/kafka? Is this still the only way to use circe with Kafka?

@joan38
Copy link
Contributor Author

joan38 commented Jul 21, 2018

Hi @DevonPeroutky

I don't think apache/kafka would like to be circe specific. The easy way to use it is to depend on:

"com.goyeau" %% "kaka-streams-circe" % "0.5"

See https://github.com/joan38/kafka-streams-circe for more info.

@DevonPeroutky
Copy link

Yeah, that's what I ended up doing. Thanks for writing this. It's exactly what I needed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants