Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: mark span with ERROR status when exception happens #2020

Open
efgpinto opened this issue Feb 7, 2024 · 3 comments
Open

Tracing: mark span with ERROR status when exception happens #2020

efgpinto opened this issue Feb 7, 2024 · 3 comments
Labels
enhancement New feature or request kalix-runtime Runtime and SDKs sub-team

Comments

@efgpinto
Copy link
Member

efgpinto commented Feb 7, 2024

When there is an unhandled exception coming from the user function, we could mark the span as Error and attach the error. E.g.

case NonFatal(ex) =>
  span.setStatus(trace.StatusCode.ERROR, ex.getMessage)

This will make it easier later on the UI. E.g. in jaeger (note the red mark and the otel.status_descriptor):
Screenshot 2024-02-07 at 15 13 19

@efgpinto efgpinto added enhancement New feature or request kalix-runtime Runtime and SDKs sub-team labels Feb 7, 2024
@efgpinto
Copy link
Member Author

efgpinto commented Feb 7, 2024

Now, after reading this I'm not so sure anymore if this is one case that warrants the error setting.

@franciscolopezsancho
Copy link
Contributor

I would have a look at https://opentelemetry.io/docs/specs/semconv/general/trace/. Maybe better than opentracing semantic conventions?

@franciscolopezsancho
Copy link
Contributor

It looks great by the way. I definitely like the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Development

No branches or pull requests

2 participants