-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different name for the abstract base class #42
Comments
I'm unsure that it is misleading... The name itself was leveraged from how we naturally referred to it within the codegen lib. Naming can be tricky of course, but be aware that the interface is needed in the spirit of namespacing protobuf generated code i.e. happy to see it changed, but watch out! ;-) |
Misleading in the way that the Java developer in me would expect it to be a Java |
I also got that feeling that it should be called And we can call the implementation |
Abstract vs Interface fixed on #99 |
Impl fixed on #109 |
Right now, the abstract base class for the Event Sourced Entity gets the suffix
Interface
which is misleading.The text was updated successfully, but these errors were encountered: