Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different name for the abstract base class #42

Closed
ennru opened this issue May 12, 2021 · 5 comments
Closed

Different name for the abstract base class #42

ennru opened this issue May 12, 2021 · 5 comments
Assignees
Labels
java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team

Comments

@ennru
Copy link
Member

ennru commented May 12, 2021

Right now, the abstract base class for the Event Sourced Entity gets the suffix Interface which is misleading.

@huntc
Copy link
Contributor

huntc commented May 12, 2021

I'm unsure that it is misleading... The name itself was leveraged from how we naturally referred to it within the codegen lib. Naming can be tricky of course, but be aware that the interface is needed in the spirit of namespacing protobuf generated code i.e. happy to see it changed, but watch out! ;-)

@ennru
Copy link
Member Author

ennru commented May 12, 2021

Misleading in the way that the Java developer in me would expect it to be a Java interface, not an abstract class.
So again, the name is overloaded from the different angles.

@octonato octonato transferred this issue from another repository Jun 16, 2021
@octonato
Copy link
Member

octonato commented Jun 16, 2021

I also got that feeling that it should be called AbstractSomething.

And we can call the implementation Something instead of SomethingImpl.

@franciscolopezsancho
Copy link
Contributor

franciscolopezsancho commented Jul 5, 2021

Abstract vs Interface fixed on #99

@franciscolopezsancho
Copy link
Contributor

franciscolopezsancho commented Jul 5, 2021

Impl fixed on #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Development

No branches or pull requests

5 participants