Allow multiple exclude files per version to be loaded from a directory #239
Conversation
So, instead of creating a single mima-filters/10.1.5.backwards.excludes file to which everyone appends, you can now create a directory with the same name containing multiple exclude files per change like that: mima-filters/10.1.5.backwards.excludes/pr1234.excludes mima-filters/10.1.5.backwards.excludes/pr5678.excludes etc. This will prevent the common merge conflicts when everyone tries to append to the same file when in fact the ordering of entries is not interesting.
jrudolph
force-pushed
the
jr/exclude-dirs
branch
from
0aff06d
to
c7dcab7
Compare
WIP on that is here: https://github.com/jrudolph/migration-manager/tree/jr/add-collection-task |
|
Great idea! I wonder if the directory name could be improved as there is some duplication right now. Something like: |
I do not think that is a big problem for git or for navigating through these files. They will even be named by the PR that introduced the incompatibility which greatly increases manageability. Also we can delete filter files for a version, when it is not being used to check compatibility anymore. |
Seems to increase duplication for me ;)
That's right, checking against old versions isn't too useful. It would need a pattern of changing (or deleting / recreating) the same API multiple times before it would actually catch anything. So, I guess it makes sense to remove old entries regularly anyway. |
It has twice as little |
Ah, I see, but it's double |
|
Yea, but it is the same number of |
|
How about not allowing any other files in those directories, then it could be |
|
Now it takes every file from the dir removing all the duplication in file names. |
…0.3.0', 'scala-steward/update/sbt-compat-1.2.6', 'scala-steward/update/config-1.3.3', 'scala-steward/update/config-1.0.2' and 'scala-steward/update/sbt-bintray-0.5.4' * scala-steward/update/sbt-mima-plugin-0.3.0: Update sbt-mima-plugin to 0.3.0 Allow multiple exclude files per version to be loaded from a directory (#239) Only handle NonFatal exceptions Don't swallow the cause Produce a better error message when files are found that cannot be processed Run it:test on Scala 2.13.0-M4 in CI * scala-steward/update/sbt-compat-1.2.6: Update sbt-compat to 1.2.6 Allow multiple exclude files per version to be loaded from a directory (#239) Only handle NonFatal exceptions Don't swallow the cause Produce a better error message when files are found that cannot be processed Run it:test on Scala 2.13.0-M4 in CI * scala-steward/update/config-1.3.3: Update config to 1.3.3 Allow multiple exclude files per version to be loaded from a directory (#239) Only handle NonFatal exceptions Don't swallow the cause Produce a better error message when files are found that cannot be processed Run it:test on Scala 2.13.0-M4 in CI * scala-steward/update/config-1.0.2: Update config to 1.0.2 Allow multiple exclude files per version to be loaded from a directory (#239) Only handle NonFatal exceptions Don't swallow the cause Produce a better error message when files are found that cannot be processed Run it:test on Scala 2.13.0-M4 in CI * scala-steward/update/sbt-bintray-0.5.4: Update sbt-bintray to 0.5.4 Allow multiple exclude files per version to be loaded from a directory (#239) Only handle NonFatal exceptions Don't swallow the cause Produce a better error message when files are found that cannot be processed Run it:test on Scala 2.13.0-M4 in CI
So, instead of creating a single
mima-filters/10.1.5.backwards.excludes
file to which everyone appends, you can now create a directory with the same name containing multiple exclude files per change like that:
mima-filters/10.1.5.backwards.excludes/pr1234.excludes
mima-filters/10.1.5.backwards.excludes/pr5678.excludes
etc.
This will prevent the common merge conflicts when everyone tries to append to the same file when in fact the ordering of entries is not interesting.
I'm thinking about also adding another task that would collect all those files
from the directory into a single file once the "version is closed", i.e. a new one was created to prevent a huge amount of filter files accruing over time.