Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code snippets now contain a button copying the contents #474

Merged
merged 4 commits into from
Feb 19, 2021

Conversation

johanandren
Copy link
Contributor

Two text buttons up top right in snippets now: [ source ] [ copy ]

This aligns the snippets with other doc tools that has a copy button up top right.

…one for copying the contents

This aligns the snippets with other doc tools that has a copy button up top right.
@ennru
Copy link
Member

ennru commented Feb 18, 2021

The functionality looks good to me.

The design less so (from Paradox own documentation)
image

The scripted test need to be adapted.

@johanandren
Copy link
Contributor Author

Ah, forgot to check the default theme after getting it to work with the akka one indeed. I'll look into the scripted tests as well.

@johanandren
Copy link
Contributor Author

Better now hopefully

Screenshot 2021-02-18 at 16 25 39

@johanandren
Copy link
Contributor Author

Both chrome and firefox messes up the fonts on those buttons though, making them the code font, I'll see if I can fix.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The next request will be to have the "copy" button on all markdown verbatim sections...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants