bump: update to parboiled 1.4.1 for JDK 17 support #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is reasonable - we build many artifacts with jdk11 already (though usually still targeting jdk8), and for those where this is hard we can stick to a previous version of paradox. |
raboof
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #491. Tests with parboiled 1.4.1 work locally. Add JDK 17 to the build matrix.
Note: but parboiled 1.4.1 is built with JDK 11. So unless parboiled has a multi-release jar added or something, this would require making JDK 11 the minimum Java version for Paradox versions going forward as well.
Marking as draft for now, while we decide on the above.