Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly state which external link failed to validate #612

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

olivergrabinski
Copy link
Contributor

During external link validation, the error message can be unhelpful:

[error] Error validating external link, status was 404 Not Found at /home/runner/work/nexus/nexus/docs/src/main/paradox/docs/faq.md:1
[error] # FAQ
[error] ^

This change explicitly states which link failed to validate

@lightbend-cla-validator
Copy link
Collaborator

Hi @olivergrabinski,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@olivergrabinski
Copy link
Contributor Author

olivergrabinski commented Apr 4, 2024

Thanks @johanandren; I had to push again to fix the formatting

@johanandren johanandren merged commit 47a9828 into lightbend:master Apr 4, 2024
5 checks passed
@johanandren johanandren modified the milestones: 0.9.3, 0.10.7 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants