-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(filters): add min value to input instead of 'or' operator #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for peaceful-bassi-cbf284 pending review. 🔨 Explore the source changes: 821087e |
Sync271
changed the title
fix: add min value to input instead of or operator
fix: add min value to input instead of Feb 26, 2022
||
operator
Sync271
changed the title
fix: add min value to input instead of
fix: add min value to input instead of 'or' operator
Feb 26, 2022
||
operator
ZeRego
changed the title
fix: add min value to input instead of 'or' operator
fix(filters): add min value to input instead of 'or' operator
Feb 28, 2022
@all-contributors add @Sync271 for code |
I've put up a pull request to add @Sync271! 🎉 |
ZeRego
approved these changes
Feb 28, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2022
## [0.28.2](0.28.1...0.28.2) (2022-02-28) ### Bug Fixes * **filters:** add min value to input instead of 'or' operator ([#1462](#1462)) ([fb144a9](fb144a9)) * **filters:** filter by null [skip ci] ([#1459](#1459)) ([64b4a51](64b4a51)) * use dbt target-path value [skip ci]([#1456](#1456)) ([8f14534](8f14534))
🎉 This PR is included in version 0.28.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre requirements:
Reference:
closes: #1452, closes: #1466
Description:
In:
lightdash/packages/frontend/src/components/common/Filters/FilterInputs/DateFilterInputs.tsx
Lines 111 to 123 in 5e742cb
whenever the field is empty, it defaults to 1, so even if you hit backspace, you can only add the number to 1 as explained in #1452
By adding a minimum value of 1, it allows you to enter any numeric value and not get default to 1.
Preview:
Lightdash - fix-numeric-input - Watch Video
Scope of the changes (select all that apply):