feat: add max row limit #3546
Merged
feat: add max row limit #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
owlas
requested a deployment
to
feat/add-row-limit - jaffle_db PR #3546
Render
Abandoned
TuringLovesDeathMetal
approved these changes
Oct 24, 2022
rephus
approved these changes
Oct 24, 2022
| onLimitChange, | ||
| }) => { | ||
| const { health } = useApp(); | ||
| const methods = useForm<{ limit: string }>({ |
There was a problem hiding this comment.
why is the limit a string and not a number ?
| methods={methods} | ||
| onSubmit={handleSubmit} | ||
| > | ||
| <Input |
There was a problem hiding this comment.
why not using a numeric input ?
There was a problem hiding this comment.
There is a really annoying behaviour when editing a number in the numeric input.
Eg: limit is 500 but you want 600. So the user deletes the 5 to then type 6. But the input instantly converts the 00 to 0 to be a valid number.
| @@ -45,3 +45,8 @@ export const isValidEmailDomain: FieldValidator<string[]> = | |||
| : undefined; | |||
| } | |||
| }; | |||
|
|
|||
| export const isOnlyNumbers: FieldValidator<string> = (fieldName) => (value) => | |||
| !value || value.match(/\D/) | |||
IrakliJani
approved these changes
Oct 24, 2022
Comment on lines
24
to
26
| useEffect(() => { | ||
| setValue('limit', limit?.toString()); | ||
| }, [limit, setValue]); |
There was a problem hiding this comment.
form has defaultValues option that you can use instead
|
|
||
| const handleSubmit = useCallback( | ||
| (data: { limit: string }) => { | ||
| console.log('handleSubmit'); |
owlas
temporarily deployed
to
feat/add-row-limit - lightdash PR #3546
Render
Destroyed
|
🎉 This PR is included in version 0.297.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3498
Description:
New env
LIGHTDASH_QUERY_MAX_LIMITthat defaults to 5000Error for saved queries that exceed the limit.