Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote charts to upstream projects #9855

Closed
owlas opened this issue Apr 23, 2024 · 3 comments · Fixed by #9895
Closed

Promote charts to upstream projects #9855

owlas opened this issue Apr 23, 2024 · 3 comments · Fixed by #9895
Assignees
Labels
✨ feature-request Request for a new feature or functionality

Comments

@owlas
Copy link
Collaborator

owlas commented Apr 23, 2024

Description

Biz logic

  • Try and promote a chart
  • Check if upstream project exists, if not throw an error
  • Find space with matching slug, if there's many error. if there's none create the space with dev space name, if there's one match, select it
  • Find chart with matching slug, if there's many error, if there's none, create chart in space with dev chart name, if there's one match, update it

Only developers on the current project can promote. Always check permissions to create / update content in the target project.

API

  • Endpoint to promote charts, could live on the chart result
  • Add upstream project uuid to project endpoint

UI

  • If upstream project exists on current project
  • If chart is in a clean state (i.e. save button is grey), then show a promote button (behind a feature flag)
  • Also add to the context menu from chart lists
  • On success link to created content
@owlas owlas added the ✨ feature-request Request for a new feature or functionality label Apr 23, 2024
@rephus
Copy link
Collaborator

rephus commented Apr 23, 2024

Find chart with matching slug, if there's many error, if there's none, create chart in space with dev chart name, if there's one match, update it

WHat happens if a charts has been moved to another space in one of the projects ? will that cause a duplicate ?

@owlas
Copy link
Collaborator Author

owlas commented Apr 23, 2024

Yes that will cause a duplicate! There are many other cases where things won't work unless we implement a sync to "pull from upstream". Right now there's no sync

@rephus rephus self-assigned this Apr 25, 2024
@rephus
Copy link
Collaborator

rephus commented Apr 26, 2024

Do you see an obvious place to put this UI for selecting a project in settings ?

image

Should we make a new promoting setting page ?

@rephus rephus mentioned this issue Apr 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature-request Request for a new feature or functionality
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants