Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff view for promoting charts #9858

Open
owlas opened this issue Apr 23, 2024 · 1 comment
Open

Add diff view for promoting charts #9858

owlas opened this issue Apr 23, 2024 · 1 comment
Assignees
Labels
✨ feature-request Request for a new feature or functionality

Comments

@owlas
Copy link
Collaborator

owlas commented Apr 23, 2024

Description

When promoting a chart would update an existing chart in production (rather than creating a new one for the first time), then the user should see a diff view explaining what's changed before confirming the promote.

@owlas owlas added the ✨ feature-request Request for a new feature or functionality label Apr 23, 2024
@rephus
Copy link
Collaborator

rephus commented Jun 6, 2024

we should use this type:

// example
type PromotionChanges = {
   spaces: [{
      action: 'create' | 'update' | 'delete';
      data: Space 
   }],
   dashboards: [{
      action: 'create' | 'update' | 'delete';
      data: Dashboard 
   }],
   charts: [{
      action: 'create' | 'update' | 'delete';
      data: Chart
   }],
}

and run permission checks based on this structure on dashboards

@rephus rephus self-assigned this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature-request Request for a new feature or functionality
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants