Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix foreign key constraint error when delete last tab #9865

Merged

Conversation

Shifan-Gu
Copy link
Contributor

@Shifan-Gu Shifan-Gu commented Apr 23, 2024

Closes:
issue:
this error would happen when delete last tab:
Screenshot 2024-04-23 at 07 46 58

and that's happening because the tab uuid referenced in the tiles is gone.

Description:

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

Copy link

netlify bot commented Apr 23, 2024

👷 Deploy request for peaceful-bassi-cbf284 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3847b71

@hamzahc1 hamzahc1 requested a review from rephus April 23, 2024 15:34
@rephus
Copy link
Collaborator

rephus commented Apr 25, 2024

Running tests ..

@owlas owlas requested a deployment to duplicate_fix/tab-delete-foreign-key-constraint-error - jaffle_db_pg_13 PR #9889 April 25, 2024 13:59 — with Render Abandoned
@owlas owlas deployed to duplicate_fix/tab-delete-foreign-key-constraint-error - headless-browser PR #9889 April 25, 2024 13:59 — with Render Active
@rephus
Copy link
Collaborator

rephus commented Apr 25, 2024

Unrelated userAttributes e2e error. Merging..

@rephus rephus merged commit 8265e7d into lightdash:main Apr 25, 2024
57 of 63 checks passed
lightdash-bot pushed a commit that referenced this pull request Apr 25, 2024
## [0.1076.4](0.1076.3...0.1076.4) (2024-04-25)

### Bug Fixes

* fix foreign key constraint error when delete last tab ([#9865](#9865)) ([8265e7d](8265e7d))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1076.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@owlas owlas temporarily deployed to duplicate_fix/tab-delete-foreign-key-constraint-error - headless-browser PR #9889 April 28, 2024 17:09 — with Render Destroyed
@owlas owlas temporarily deployed to duplicate_fix/tab-delete-foreign-key-constraint-error - lightdash PR #9889 April 28, 2024 17:09 — with Render Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants