Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tab delete modal should be more explicit about which tiles/charts you will delete #9870

Closed
3 tasks
PriPatel opened this issue Apr 24, 2024 · 0 comments
Closed
3 tasks
Labels
ux For annoying UX things/small changes to the UX that have big impacts.

Comments

@PriPatel
Copy link
Contributor

PriPatel commented Apr 24, 2024

1. If there is more than one tab:

  • and the dashboard only contains saved charts / other tile types: (ie. no saved charts created within the dashboard)
    Are you sure you want to remove tab *Tab Name* and ‘X’ tiles from this dashboard?

2. If there is more than one tab:

  • and the dashboard contains charts saved from within a dashboard:
Are you sure you want to remove tab ‘Tab Name’ and 'X' tiles from this dashboard?
Once you save changes to your dashboard, this action will also permanently delete the following charts that were created from within it:
- 'Chart name 1'
- 'Chart name 2'

3. If there are no tiles in the tab:

  • There is no need to show a modal!

For the reviewer

Check the output when the user deletes :

  • A tab that has no tiles
  • A tab that has no charts created from within the dashboard ( it only has saved charts / loom / markdown)
  • A tab that has charts created from within the dashboard
@PriPatel PriPatel added the ux For annoying UX things/small changes to the UX that have big impacts. label Apr 24, 2024
@PriPatel PriPatel added this to the ⏭️ Dashboard Tabs milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux For annoying UX things/small changes to the UX that have big impacts.
Projects
None yet
Development

No branches or pull requests

1 participant