fix: remove duplicated rules #9876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlas
requested a deployment
to
fix-dashboard-chart-filter-override - jaffle_db_pg_13 PR #9876
Render
Abandoned
owlas
deployed
to
fix-dashboard-chart-filter-override - headless-browser PR #9876
Render
Active
almeidabbm
requested review from
a team and
joaoviana
and removed request for
ZeRego,
a team and
joaoviana
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
owlas
temporarily deployed
to
fix-dashboard-chart-filter-override - lightdash PR #9876
Render
Destroyed
owlas
temporarily deployed
to
fix-dashboard-chart-filter-override - headless-browser PR #9876
Render
Destroyed
rephus
reviewed
Apr 25, 2024
|
|
||
| const overriddenGroup = overrideChartFilter(filterGroup, filterRules); | ||
|
|
||
| // deduplicate the dashboard filter rules from the ones used when overriding the chart filterGroup |
There was a problem hiding this comment.
I guess this is ok because we recently said chart filters should NOT be used for limiting data access...
|
Triggering tests |
rephus
approved these changes
Apr 26, 2024
lightdash-bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
## [0.1076.5](0.1076.4...0.1076.5) (2024-04-26) ### Bug Fixes * remove duplicated rules ([#9876](#9876)) ([fe79ee7](fe79ee7))
|
🎉 This PR is included in version 0.1076.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9840
Description:
Screen.Recording.2024-04-24.at.16.10.46.mov
Reviewer actions
test-frontend test-backend