Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison with torch.compile instead of Eager #33

Closed
bonlime opened this issue Mar 21, 2024 · 3 comments
Closed

Comparison with torch.compile instead of Eager #33

bonlime opened this issue Mar 21, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@bonlime
Copy link

bonlime commented Mar 21, 2024

馃摎 Documentation

Hey! I saw your tool and plots with "acceleration", but you compare to un-optimised eager torch, which is obviously slower. Could you provide a graph with comparison against basic native pytorch loop, where you torch.compile the model? It would be useful for people who already have some optimisations in their pipelines, but would like to try yours framework instead

Thanks

@bonlime bonlime added the documentation Improvements or additions to documentation label Mar 21, 2024
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@t-vi
Copy link
Collaborator

t-vi commented Mar 21, 2024

We love torch.compile and use it a lot, too, and when enabling it in thunder (and perhaps disabling other backends) we expect numbers to be in the same ballpark. Do try it out!
That said, PyTorch eager is a more stable anchor point for us (maybe like the Prototype Metre in olden times), so we think it is most useful to our measurement.

@lantiga
Copy link
Collaborator

lantiga commented Mar 22, 2024

Thank you @bonlime, as @t-vi wrote our baseline is eager.
We are all about compounding the effect of multiple optimizations and have torch.compile in the mix.

In the case of the plot it was roughly equivalent to the first bar in that particular experiment, but again, we are not interested in a head to head comparison as it would be misleading with respect to the goals of the project.

@lantiga lantiga closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants