Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose parameters with overrides in ThunderModule . #453

Closed
t-vi opened this issue May 24, 2024 · 0 comments · Fixed by #466
Closed

Expose parameters with overrides in ThunderModule . #453

t-vi opened this issue May 24, 2024 · 0 comments · Fixed by #466
Assignees
@t-vi
Labels
bug Something isn't working distributed

Comments

@t-vi
Copy link
Collaborator

t-vi commented May 24, 2024 •
edited
Loading

Currently, .parameters() etc. gives the original params, we should consider overrides in this.

This affects distributed for FSDP-as-a-transform the upcoming Tensor Par etc.

cc @carmocca @awaelchli @crcrpar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-vi t-vi

Labels
bug Something isn't working distributed
Projects
None yet
Milestone
No milestone
1 participant
@t-vi