Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply the ignore of the save_hyperparameters function to args as well. #19761

Open
doveppp opened this issue Apr 11, 2024 · 0 comments
Open

Apply the ignore of the save_hyperparameters function to args as well. #19761

doveppp opened this issue Apr 11, 2024 · 0 comments
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers

Comments

@doveppp
Copy link

doveppp commented Apr 11, 2024 •
edited by github-actions bot
Loading

Description & Motivation

Currently, the ignore parameter of the save_hyperparameters function only filters its own arguments.

Can we apply hp = {k: v for k, v in hp.items() if k not in ignore} before obj._set_hparams(hp)?

image

Pitch

No response

Alternatives

No response

Additional context

No response

cc @Borda
@doveppp doveppp added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doveppp