Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download documentation needs updating, --repo_id required #44

Closed
Sciumo opened this issue May 9, 2023 · 3 comments
Closed

Download documentation needs updating, --repo_id required #44

Sciumo opened this issue May 9, 2023 · 3 comments

Comments

@Sciumo
Copy link

Sciumo commented May 9, 2023

Document says:

python scripts/download.py stabilityai/stablelm-base-alpha-3b

Actually required

python scripts/download.py --repo_id stabilityai/stablelm-base-alpha-3b

I could just make edits as I go along and send PR if you wish.

@carmocca
Copy link
Contributor

Please do! You can also set as_positional=False in https://github.com/Lightning-AI/lit-parrot/blob/main/scripts/download.py#L35 and then it won't require --repo_id

@Sciumo
Copy link
Author

Sciumo commented May 10, 2023

Okay. I'll include some sanity and a fix as well.
Not sure how convert_hf_checkout.py ever worked since the check_valid_checkpoint_dir looks for lit_model.pth and lit_config.json doesn't even exist yet.

@carmocca
Copy link
Contributor

This was fixed in #48. Thank you for reporting

aniketmaurya pushed a commit to aniketmaurya/install-lit-gpt that referenced this issue Jul 5, 2023
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants