Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link to Edit in Github is broken #26

Closed
edgarriba opened this issue Jun 11, 2021 · 4 comments
Closed

link to Edit in Github is broken #26

edgarriba opened this issue Jun 11, 2021 · 4 comments
Labels
bug / fix Something isn't working help wanted Extra attention is needed

Comments

@edgarriba
Copy link
Contributor

馃悰 Bug

The link Edit in Github in the generated docs is broken

image
@edgarriba edgarriba added bug / fix Something isn't working help wanted Extra attention is needed labels Jun 11, 2021
@Borda Borda assigned Borda and unassigned Borda Jun 11, 2021
@Borda
Copy link
Member

Borda commented Jun 12, 2021

not sure if this is possible to solve as the link to gis correct, just GH is not able t propagate the link throw submodule
so for example this target file almost correct except the notebooks is a submodule
https://github.com/PyTorchLightning/pytorch-lightning/blob/master/docs/source/notebooks/starters/datamodules.ipynb
image

@Borda Borda added the won't fix This will not be worked on label Jun 12, 2021
@edgarriba
Copy link
Contributor Author

Hardcoded in style files?

@stale stale bot removed the won't fix This will not be worked on label Jun 12, 2021
@Borda
Copy link
Member

Borda commented Jun 12, 2021

not sure what you mean, the Edit in Github is generated for all files by sphinx template/extension

@Borda
Copy link
Member

Borda commented Jun 13, 2021

closing for now as this is dependent on target integrated docs and used sphinx template 馃惏

@Borda Borda closed this as completed Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug / fix Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edgarriba @Borda