Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

building notebooks in parallel for tests & publish #48

Closed
Borda opened this issue Jun 25, 2021 · 3 comments 路 Fixed by #215
Closed

building notebooks in parallel for tests & publish #48

Borda opened this issue Jun 25, 2021 · 3 comments 路 Fixed by #215
Labels
ci/cd enhancement New feature or request help wanted Extra attention is needed Priority High priority task

Comments

@Borda
Copy link
Member

Borda commented Jun 25, 2021

馃殌 Feature

Dynamically extend the time limit for running CI on PR touching more content

Motivation

do not penalise PR which are touching multiple notebooks

Additional context

Run one tiny job which would determine how many notebooks are changed, and pass this count N to the test job and for example set timeout for testing as N*30min

@Borda Borda added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 25, 2021
@Borda Borda added this to To do in Improve CI/CD Aug 1, 2021
@Borda Borda added the ci/cd label Dec 4, 2021
@Borda
Copy link
Member Author

Borda commented Dec 5, 2021

@Borda
Copy link
Member Author

Borda commented Apr 10, 2022

another an even better way would be building notebooks in parallel
similar to Lightning-AI/torchmetrics#764 and Lightning-AI/ecosystem-ci#18

For publishing, it is rather simple, as the git merge goes in CPU job, and each consecutive notebook will be its own job with...
For testing it is rather tricky as the testing shall be required check so not sure yet how to include all dynamic jos... 馃惏

@Borda Borda added Priority High priority task and removed good first issue Good for newcomers labels Jan 1, 2023
@Borda Borda changed the title dynamically adjust testing timeout building notebooks in parallel for tests & publish Jan 1, 2023
@Borda
Copy link
Member Author

Borda commented Jan 1, 2023

yep, so the initial job will generate a list of needed builds and handle eventual removals, and then all particular jobs could even have larger customization such as OS or Python versions... 馃Ζ

Multi-job configuration

@Borda Borda closed this as completed in #215 Jan 3, 2023
Improve CI/CD automation moved this from To do to Done Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd enhancement New feature or request help wanted Extra attention is needed Priority High priority task
Projects
Development

Successfully merging a pull request may close this issue.

1 participant