Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pytorch Lightning's LightningDataModule #129

Closed
nateraw opened this issue Jul 28, 2020 · 1 comment 路 Fixed by #130
Closed

Use Pytorch Lightning's LightningDataModule #129

nateraw opened this issue Jul 28, 2020 · 1 comment 路 Fixed by #130
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@nateraw
Copy link
Contributor

nateraw commented Jul 28, 2020

馃殌 Feature

Refactor to reflect the built-in LightningDataModule that has been implemented directly into lightning by removing the same code here and replacing with references to pl.LightningDataModule

Motivation

Pytorch Lightning version 0.9.0 implements the LightningDataModule directly in lightning. We have no need for the bolts implementation once that version is released, so we should update the code here accordingly.

Pitch

I suggest we merge a fix for this as soon as the stable version of 0.9.0 has been released. We could do it earlier, but something bothers me about having a prerelease in requirements.txt 馃槄

Alternatives

Additional context

The implementation is nearly the same and should cause no conflicts.

  • The code can be found here
  • The docs can be found here
@nateraw nateraw added enhancement New feature or request help wanted Extra attention is needed labels Jul 28, 2020
@github-actions
Copy link

Hi! thanks for your contribution!, great first issue!

@nateraw nateraw mentioned this issue Jul 28, 2020
4 tasks
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants