Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor each RL model to not use hparams #42

Closed
williamFalcon opened this issue Jun 20, 2020 · 1 comment
Closed

Refactor each RL model to not use hparams #42

williamFalcon opened this issue Jun 20, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation
Projects
Reinforcement Learning

Comments

@williamFalcon
Copy link
Contributor

@djbyrne

Goal is to allow each model to init like:

from pl_bolts.models.rl import DQN

model = DQN()

But some models might have required params (but most should have good defaults).

https://files.slack.com/files-pri/TR9DVT48M-F0164T0P03B/image.png
@williamFalcon williamFalcon added the documentation Improvements or additions to documentation label Jun 20, 2020
@williamFalcon williamFalcon added this to the RL library milestone Jun 20, 2020
@djbyrne
Copy link
Contributor

djbyrne commented Jun 25, 2020

This should be completed here #56

@Borda Borda removed this from the v0.3 milestone Nov 20, 2020
@Borda Borda added this to Done in Reinforcement Learning Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Reinforcement Learning
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@williamFalcon @djbyrne @Borda