Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reliance on RxSwift fork #1

Open
UnknownJoe796 opened this issue Mar 21, 2022 · 0 comments
Open

Remove reliance on RxSwift fork #1

UnknownJoe796 opened this issue Mar 21, 2022 · 0 comments

Comments

@UnknownJoe796
Copy link
Collaborator

Right now, the library doesn't work unless you used a forked version of RxSwift that enables us to implement our own subjects and observables.

I'd like to remove this requirement either by:

  • Getting a PR merged into RxSwift
    • Might be a struggle because it's a big ask - the PR would require marking some internal APIs as open
  • Using the protocols instead
    • Ruins the ability to store ValueSubject<T> as a Subject<T> which would make translations really difficult

Either option could be difficult, but I think we should start by seeing what the RxSwift people are willing to do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UnknownJoe796