Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: Add itest-race target in Makefile #891

Open
gijswijs opened this issue Apr 25, 2024 · 1 comment
Open

[enhancement]: Add itest-race target in Makefile #891

gijswijs opened this issue Apr 25, 2024 · 1 comment
Assignees
Labels
CI enhancement New feature or request itests

Comments

@gijswijs
Copy link
Contributor

Background

Itest fail sometimes on CI while passing locally. This led to a discussion about making make itest-race part of the CI.
Whether we do add it to CI or we don't, having the Makefile target makes sense. The decision to add it to the CI can be made at a later stage.

Deliverables

Makefile target itest-race similar to the homonymous target in lnd.

@gijswijs gijswijs added the enhancement New feature or request label Apr 25, 2024
@gijswijs gijswijs self-assigned this Apr 25, 2024
@gijswijs
Copy link
Contributor Author

Would we need to build the lnd binary with the -race flag? Or only run go test with the -race flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request itests
Projects
Status: 💇‍♂️Needs Shaping
Development

No branches or pull requests

2 participants