Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Use more sophisticated margin for invoice acceptor #920

Open
GeorgeTsagk opened this issue May 28, 2024 · 0 comments
Open

[feature]: Use more sophisticated margin for invoice acceptor #920

GeorgeTsagk opened this issue May 28, 2024 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@GeorgeTsagk
Copy link
Member

Background

Currently our invoice acceptor for lightning payments has some room for error for the amount sent by the sending party. Due to inaccuracies that may be produced by translating an asset to msat, we want to still accept invoices that are slightly off.

For assets with very high value this behavior may be taken advantage of by malicious senders, as they may try to abuse this artificial breathing room to their advantage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant