Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Migrate Decimal Display into TLV to induce availability and protocol-level enforcement #956

Open
3 tasks
dstadulis opened this issue Jun 18, 2024 · 0 comments

Comments

@dstadulis
Copy link
Collaborator

dstadulis commented Jun 18, 2024

Description:

To ensuring correct decimal display usage the daemon has recently added checks inside the planter (added in #952) this should catch inadvertent user errors (if a user is using a tapd daemon). This is substandard as the protocol-design need is to entwine the value with the endogenous properties of an asset -- e.g. inextricably link decimal_display into the asset.

Proposed Solution:

Move the decimal display value into the asset's TLV. This would make it an integral part of the asset's property and enforce on the protocol level consistency.

Benefits

  1. This will enforce consistency decimal display value across any taproot asset implementation (or hacky uses of tapd) and light client by making it inherent to the asset

Implementation Plan

To implement this solution, we will:

  • Update the TLV to include decimal display information.
  • Modify the RPC/API interfaces to accommodate the updated TLV structure.
  • Refactor the verification logic to utilize the TLV-based decimal display.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants