Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Support asset script reuse during minting #966

Open
gijswijs opened this issue Jun 24, 2024 · 1 comment
Open

[feature]: Support asset script reuse during minting #966

gijswijs opened this issue Jun 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@gijswijs
Copy link
Contributor

Currenlty the mintin process does not allow for explicitly creating multiple assets from different asset IDs with the same script key. During MarkBatchConfirmed we use the script key as the unique identifier for the asset. We should add the actual 32-byte asset ID into that query to support asset script reuse over different Asset IDs.

func (a *AssetMintingStore) MarkBatchConfirmed(ctx context.Context,

@jharveyb
Copy link
Collaborator

Now that users can provide external script keys, many of the assumptions about per-batch script key uniqueness are now invalid. The only enforced-unique field for batches is the asset name.

We could use TapCommitmentKey() + AssetCommitmentKey() as the unique ID here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants